Quill editor: Make toolbar visible on long texts #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the ql-toolbar to sticky so now the toolbar is always visible regardless of the editor's height. Should make formatting long texts easier
The way header was implemented caused some overlapping with other DOM elements such as Quill Editor, which made the toolbar ineffective when the ql editor's height is big enough
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
ani-kalpachka
approved these changes
Jul 4, 2023
ani-kalpachka
added
the
run tests
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the toolbar position
stickyso it always stays visible within the parent's sizeFixed the admin header as it was conflicting with other DOM elements, primarily with Quill's toolbar, which made the toolbar buttons ineffective.
Closes #1439
Motivation and context
Requested feature.